Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducibility issue in 0.17.5 #1788

Closed
DFINITYManu opened this issue Nov 1, 2023 · 2 comments
Closed

Reproducibility issue in 0.17.5 #1788

DFINITYManu opened this issue Nov 1, 2023 · 2 comments

Comments

@DFINITYManu
Copy link

DFINITYManu commented Nov 1, 2023

After 0.16.20 which was perfectly reproducible no matter the path to the project including ring, 0.17.5 has reproducibility issues.

image

What you are looking at is the same program built under directories metrics-proxy and petrics-mroxy, but with the RUSTFLAGS='--remap-path-prefix=/home/manuel/src/petrics-mroxy=/home/manuel/src/metrics-proxy' which ensures both should be identical -- and they are, so long as the ring version is 0.16.20, but not with 0.17.5.

We have mitigated using the CFLAGS trick mentioned in #715 but we would prefer not to have to do this.

Thanks in advance!

@briansmith
Copy link
Owner

Closing as a duplicate of #715. I don't know why/how 0.16.20 didn't have the same issue, BTW.

@briansmith briansmith closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2023
@DFINITYManu
Copy link
Author

I found the reason why 0.16.20 here was working... the CFLAGS trick was being used and I did not notice it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants