-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building with MSVC even when the Windows XP compatibility support isn't installed #336
Comments
I filed rust-lang/rust#37638 to get the Rust toolchain to give us the necessary information. Also, extending #321 to -MSVC targets might make this partially or completely unnecessary. Conversely, we might not be able to extend #321 to non-MSVC targets easily if the gcc crate can't handle this. In the meantime, we could add a "xp-compatible" feature to ring that is off-by-default, and which can be enabled by the application if they want to target XP too. |
Note that since we don't test on Windows XP, we might be relying on features that don't even work on Windows XP. So, we should probably just change the default now and punt the real Windows XP support to another bug. |
We only need add a link parameter to make sure the subsystem to be 5.01, there is no need the toolchain v140_xp |
I'd like to see some documentation for this. In particular, I'd like to see some documentation that says it's OK to compile C and C++ code using MSVC toolchain v140 and then run the resulting code on XP. |
@briansmith, Well, that's for sure, I am tested with that, and v140_xp are also do the same things. |
From #330:
Since stock rustc doesn't support Windows XP as a target, we should only use the Windows-XP-compatible toolchain when it is specifically requested, probably.
The text was updated successfully, but these errors were encountered: