Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure crypto instructions are used on AAarch32 & AAarch64 when available. #387

Open
briansmith opened this issue Dec 22, 2016 · 5 comments

Comments

@briansmith
Copy link
Owner

Grep for BORINGSSL_CLANG_SUPPORTS_DOT_ARCH. We need to ensure that that code is enabled in all AAarch32 and AAarch64 builds that use dynamic feature detection. Note that the Perl code seems to say that it is 64-bit only. I'm not sure if that's intended.

@briansmith
Copy link
Owner Author

briansmith commented Dec 22, 2016

@briansmith
Copy link
Owner Author

See also https://boringssl-review.googlesource.com/c/4411/1/crypto/aes/asm/aesv8-armx.pl#43, in particular the way that PerlAsm sometimes treats .arch as a no-op.

@briansmith
Copy link
Owner Author

Depends on the refactoring in #408, at least.

@pietro
Copy link
Contributor

pietro commented Mar 10, 2017

After #473 I think we can always define BORINGSSL_CLANG_SUPPORTS_DOT_ARCH on android.

@valpackett
Copy link

I recently landed FreeBSD/aarch64 support in stdsimd (by using the mrs instruction in userspace) rust-lang/stdarch#611 — that method is also supported on Linux since 4.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants