Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish between server and client errors #101

Open
briggySmalls opened this issue Jan 2, 2021 · 1 comment
Open

Distinguish between server and client errors #101

briggySmalls opened this issue Jan 2, 2021 · 1 comment

Comments

@briggySmalls
Copy link
Owner

Currently the auth.middleware checks for the account ID and for permissions for accessing the endpoint.

But any errors are interpreted as an InternalServerError, including if the client's token doesn't give them permission to access the account they are requesting, which should be some sort of BadRequest.
@briggySmalls
Copy link
Owner Author

https://lockmedown.com/when-should-you-return-404-instead-of-403-http-status-code/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briggySmalls