Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on 'safe_filename' from 'bw_processing' causes import error #78

Closed
PascalLesage opened this issue Aug 5, 2020 · 3 comments
Closed

Comments

@PascalLesage
Copy link
Contributor

I'm trying to contribute to bw2io (add SimaPro 3.4 and 3.5 mappings).
I followed the following steps:

All this seems to work as normal, but unfortunately, a May 26 commit has added a dependency to bw_processing and is preventing me from importing bw2io.

@PascalLesage
Copy link
Contributor Author

Of course, the obvious workaround (that works well) is to clone and install the latest version of bw_processing.

@PascalLesage
Copy link
Contributor Author

And while the fix works on one's computer, automatic testing on github fails when submitting a PR.

@cmutel
Copy link
Member

cmutel commented Feb 24, 2021

Fixed. 0.8 release is on the legacy branch, with no bw_processing dependency, while bw_processing is explicitly a dependency on development branch.

@cmutel cmutel closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants