Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: make downspeedgraph and upspeedgraph use same scaling #1820

Closed
Caellian opened this issue Apr 12, 2024 · 2 comments · Fixed by #1991
Closed

[Enhancement]: make downspeedgraph and upspeedgraph use same scaling #1820

Caellian opened this issue Apr 12, 2024 · 2 comments · Fixed by #1991
Labels
enhancement Issue that suggests an enhancement good first issue Great issues for first-time contributors sources PR modifies project sources

Comments

@Caellian
Copy link
Collaborator

It might be better to clamp downspeedgraph and upspeedgraph according to maximum value across both graphs because people assume (#979, #1034) they're using the same vertical step.
@Caellian Caellian added enhancement Issue that suggests an enhancement good first issue Great issues for first-time contributors labels Apr 12, 2024
@Caellian Caellian changed the title [Suggestion]: make downspeedgraph and upspeedgraph use same scaling [Enhancement]: make downspeedgraph and upspeedgraph use same scaling Apr 12, 2024
@Caellian Caellian added the sources PR modifies project sources label Apr 15, 2024
@donutAnees
Copy link
Contributor

I noticed that the issue is still open, and I would like to contribute to it. Please let me know if it's still available.

@Caellian
Copy link
Collaborator Author

Yup, any "good first issue" issues are if they don't have any linked PRs with recent activity.

@donutAnees donutAnees mentioned this issue Jul 20, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue that suggests an enhancement good first issue Great issues for first-time contributors sources PR modifies project sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made upspeedgraph and downspeed graph scale on a common axis
2 participants
@Caellian @donutAnees