Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: upload_invocations() fails on the dbt-databricks 1.5.0 #307

Closed
henrikamnas opened this issue May 10, 2023 · 2 comments
Closed

[Bug]: upload_invocations() fails on the dbt-databricks 1.5.0 #307

henrikamnas opened this issue May 10, 2023 · 2 comments
Labels
bug Something isn't working priority Priority issue or pull request

Comments

@henrikamnas
Copy link

henrikamnas commented May 10, 2023

Overview

Seems the invocation_args_dict has changed so that the json parsing failes here:
'{{ tojson(invocation_args_dict) | replace('\', '\\') }}', {# invocation_args #}

Let me know if there is anything I can do to help, this is a great package!

How to reproduce

  1. upgrade dbt-databricks to 1.5.0 or above
  2. run any dbt command using dbt-artifacts on-run-end

Expected behaviour

To the command to succeed with invocations data uploaded

Screenshots

Environment

Results of running dbt --version:

# Add the results here

packages:

  • package: brooklyn-data/dbt_artifacts
    version: 2.3.0
@henrikamnas henrikamnas added the bug Something isn't working label May 10, 2023
@glsdown
Copy link
Contributor

glsdown commented May 12, 2023

Hi @henrikamnas thanks for raising (and sharing your ❤️ for our package).

We are prioritising support for 1.5 now, so will be looking into this asap. The same issue has also been reported in #296 . I am hoping it will be a simple fix to do, but I can't promise on timelines at the moment I'm afraid.

@glsdown glsdown added the priority Priority issue or pull request label May 12, 2023
@glsdown glsdown mentioned this issue May 12, 2023
12 tasks
@glsdown
Copy link
Contributor

glsdown commented May 25, 2023

Hi @henrikamnas . Thanks for your patience whilst we resolved this. We have just published a release 2.4.0 which should resolve this issue. Please feel free to reopen it though if you find it doesn't solve it.

@glsdown glsdown closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority Priority issue or pull request
Projects
None yet
Development

No branches or pull requests

2 participants