Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer not found #403

Closed
mrcnski opened this issue May 11, 2022 · 4 comments · Fixed by #409
Closed

rust-analyzer not found #403

mrcnski opened this issue May 11, 2022 · 4 comments · Fixed by #409

Comments

@mrcnski
Copy link
Contributor

mrcnski commented May 11, 2022

rust-analyzer was not installed for me automatically, although it seems to be the default lsp-server for Rustic.

I had to go here and manually install it:

https://rust-analyzer.github.io/manual.html#installation

I also needed to change the client before everything finally worked:

(setq rustic-lsp-client 'eglot)

The Readme should be updated to mention these fixes in Installation as well as Troubleshooting. I spent a lot of time scouring the web to find out about these fixes.

Dropping this here in case it helps someone else.

@brotzeit
Copy link
Owner

I understand that it can be confusing with all the different packages, but automatic server installation is a lsp client feature. rustic only provides some code that's supposed to simplify setting up lsp.

I'm not sure why you had to use eglot, but sometimes rust-analyzer changes options that then has to be updated in lsp clients like emacs-lsp/lsp-mode@d117866

Thanks for helping others this way, but I'm often not sure how to document this kind of issues so it's helpful for other users. Do you think this would have helped you #409 ?

@mrcnski
Copy link
Contributor Author

mrcnski commented May 31, 2022

Hi @brotzeit, thanks for taking a look. The doc changes look great, though I still have a request. I would have expected a note about manual installation in the Installation section. And perhaps also a clarification on the phrase

most stuff gets configured automatically.

which led me to believe that rustic would install everything needed. So, adding a quick note here linking to the "LSP automatic installation" section would go a long way to alleviating confusion.

Thanks again!

@mrcnski
Copy link
Contributor Author

mrcnski commented May 31, 2022

I'll raise a quick PR.

@brotzeit
Copy link
Owner

That would be great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants