Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases and examples are uploaded to NPM #207

Closed
tbodt opened this issue Jan 22, 2020 · 2 comments
Closed

Test cases and examples are uploaded to NPM #207

tbodt opened this issue Jan 22, 2020 · 2 comments

Comments

@tbodt
Copy link

tbodt commented Jan 22, 2020

Should be pretty easy to fix by whitelisting the necessary files in package.json:

{
  "files": [
    "lib",
    "index.js"
  ]
}
@ljharb
Copy link
Member

ljharb commented Jan 22, 2020

There’s nothing to fix; they’re included by design. npm install foo && npm explore foo && npm install && npm test should always work.

Separately, the files field is very dangerous and should be avoided in favor of npmignore.

Duplicate of #171. Duplicate of #180. See not just #82, but #149 (review), #132 (review), #128 (review), #59 (comment),
#164 (comment), #171 (comment)

@ljharb ljharb closed this as completed Jan 22, 2020
@tbodt
Copy link
Author

tbodt commented Jan 22, 2020

TIL about npm explore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants