Skip to content
This repository has been archived by the owner on May 27, 2019. It is now read-only.

option to copy username/password to clipboard. #105

Closed
james-lawrence opened this issue Jul 7, 2017 · 7 comments
Closed

option to copy username/password to clipboard. #105

james-lawrence opened this issue Jul 7, 2017 · 7 comments

Comments

@james-lawrence
Copy link

for pages that fail to autofill a nice feature would be to allow copying fields to the clipboard.

@maximbaz
Copy link
Member

maximbaz commented Sep 28, 2017

Right-clicking on a row is not intuitive, I'm afraid nobody will guess that such functionality exists 🙂

My suggestions:

  • Have two buttons (with icons) on the right side of every entry, one to copy username, another to copy password.
  • Handle Ctrl+C (is it Cmd+C on Mac?) and copy the password of the currently focused entry (this item is for keyboard users).

@maximbaz
Copy link
Member

maximbaz commented Oct 5, 2017

We have a very powerful support for keyboard users, definitely not everyone is interacting with the plugin with the mouse 🙂

That's why I want to see this feature implemented in two ways, for mouse users and for keyboard users. We can discuss how to best implement it for mouse users, we can discuss how to best implement it for keyboard users, but whatever we choose for "mouse approach" will not substitute the "keyboard approach".

Now, for those who use mouse, we have two ideas now - right click on an entry, or left-clicking on one of two new buttons. I vote for the buttons because it is more intuitive, a random user who sees such buttons can immediately understand what they do. This is very approximate on how I imagine it:

browserpass_icons

For those who use keyboard, Ctrl+C (Cmd+C on Mac?) is the only idea that we have so far, and seems quite intuitive to me 🙂 This will copy password, which I guess is more important than copying a username. For copying a username, either we come up with a second shortcut (needs to be intuitive), or we just say "grab a mouse and click on the button to copy username". I can't think of a good intuitive shortcut for copying username right now.

@Weker01
Copy link
Contributor

Weker01 commented Nov 9, 2017

Is someone working on this?

@maximbaz
Copy link
Member

maximbaz commented Nov 9, 2017

Don't think so, wanna give it a try? 😉

@Weker01
Copy link
Contributor

Weker01 commented Nov 9, 2017

Time to dive into a Codebase I know nothing about. I will try implementing something on the chrome side first.

@maximbaz
Copy link
Member

maximbaz commented Nov 9, 2017

Awesome! Feel free to create an early PR and ask any questions, I got acquainted with the codebase recently and can give you some hints.

Good news, the code is shared across browsers, so you only need to touch the files in chrome folder 🙂

CONTRIBUTING.md should be of some help post-processing the javascript code. Since you are likely not touching any backend code, you can skip all the steps for the host Go binary.

@maximbaz
Copy link
Member

Thanks to @Weker01 this has been implemented 🎉 We have now buttons to copy username and password to clipboard. The keyboard shortcuts are also available, Ctrl+C copies password and Shift+C copies username.

The new release will be made later today that includes this feature 😉

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants