Skip to content
This repository has been archived by the owner on May 27, 2019. It is now read-only.

The search box is not autofocused in FF when popup is opened #155

Closed
maximbaz opened this issue Sep 25, 2017 · 7 comments
Closed

The search box is not autofocused in FF when popup is opened #155

maximbaz opened this issue Sep 25, 2017 · 7 comments

Comments

@maximbaz
Copy link
Member

General information

  • Operating system + version: ArchLinux
  • Browser + version: FF 55.0.3
  • If installed an official release, put a release version:
  • If built from sources, put a commit id ($ git describe --always): c3a6279
  • Browserpass extension version as reported by your browser: 1.0.15

Exact steps to reproduce the problem

  1. Install the extension on Firefox
  2. Hit the hotkey Alt+Shift+L

What should happen?

The search input box should autofocus, ready to receive search term, just like on Chrome.

What happened instead?

Need to press Tab, Tab to get to the search box.


May be somewhat related to #40.

@turboMaCk
Copy link
Contributor

I think we can use this lifecycle hook on the very top component to make a check if the input is selected. In case it's not we can use standard DOM API to do select via script. What do you think?

@maximbaz
Copy link
Member Author

Both ideas worth a try, I'd also start with the oncreate hook :)

If you are considering to play with this, maybe see if you can combine it together with #40? If popup opens and there is at least one result, the focus should be on the first result, otherwise on the search box.

@turboMaCk
Copy link
Contributor

Also, I agree that this #40 (comment) feature would be nice. Anyway, I would suggest to do it one by one. First, start with solving autofocus issue and then adding detection about what should be focused once popup is opened.

@maximbaz
Copy link
Member Author

I'm fine with doing it one by one 👍

@turboMaCk
Copy link
Contributor

I'll start working on it after dinner then. I think it won't take much time.

@maximbaz
Copy link
Member Author

maximbaz commented Oct 8, 2017

Awesome job with this bug 👍
Wanna tackle #40 (comment) next? There's no rush, whenever you have time 🙂

@phryneas
Copy link

phryneas commented Nov 1, 2017

Hey there, I was just experiencing the same problem and the mailing list led me to this open Issue in the Firefox Bug Tracker - you might want to monitor that too :)
https://bugzilla.mozilla.org/show_bug.cgi?id=1324255

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants