Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main function fatal exception throws #89

Closed
brson opened this issue Oct 13, 2022 · 0 comments
Closed

Fix main function fatal exception throws #89

brson opened this issue Oct 13, 2022 · 0 comments
Milestone
M2

Comments

@brson
Copy link
Owner

brson commented Oct 13, 2022

Since we made Fatal throw in binaryen, many errors will now throw out of the C++ main function. We need to catch those exceptions, error and exit the way native wasm-opt would.
@brson brson added this to the M2 milestone Oct 13, 2022
@brson brson closed this as completed in aad5633 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M2
Development

No branches or pull requests
1 participant
@brson