Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in the total_number_of_unique_words_no_lemma function #28

Open
chaojiang06 opened this issue Mar 29, 2024 · 1 comment
Open

bug in the total_number_of_unique_words_no_lemma function #28

chaojiang06 opened this issue Mar 29, 2024 · 1 comment

Comments

@chaojiang06
Copy link

chaojiang06 commented Mar 29, 2024

Hi, dear author, thank you for your awesome work! I want to bring your attention to a possible bug in the implementation of total_number_of_unique_words_no_lemma function

In lines 194-195 of file lftk/foundation/wordsent.py, the total_number_of_unique_words_no_lemma function still does the lemma operation, even though no lemma is specified. This makes the "total_number_of_unique_words_no_lemma" function almost identical to total_number_of_unique_words.

This will lead to an error that corr_ttr is same as corr_ttr_no_lem

@chaojiang06 chaojiang06 changed the title bug in the "total_number_of_unique_words" function bug in the "total_number_of_unique_words_no_lemma" function Mar 29, 2024
@chaojiang06 chaojiang06 changed the title bug in the "total_number_of_unique_words_no_lemma" function bug in the total_number_of_unique_words_no_lemma function Mar 29, 2024
@brucewlee
Copy link
Owner

i'll look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants