Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consensus conflict caused by maxWitnessItemsPerInput #1906

Closed
brqgoo opened this issue Nov 1, 2022 · 1 comment · Fixed by #1907
Closed

Consensus conflict caused by maxWitnessItemsPerInput #1906

brqgoo opened this issue Nov 1, 2022 · 1 comment · Fixed by #1907

Comments

@brqgoo
Copy link

brqgoo commented Nov 1, 2022

Bitcoin has a consensus rule that limits the number of stack items in a row to 1000. However, a P2TR spend containing OP_SUCCESSx precedes this rule regardless.

I made a P2TR spend containing an OP_SUCCESSx opcode with 500,001 empty pushes, which as a result, caused a consensus conflict between btcd and core:
https://blockstream.info/tx/73be398c4bdc43709db7398106609eea2a7841aaf3a4fa2000dc18184faa2a7e

Changing the maxWitnessItemsPerInput parameter from 500,000 to 4,000,000 solves the issue:
https://github.com/btcsuite/btcd/blob/master/wire/msgtx.go#L103
@mutatrum mutatrum mentioned this issue Nov 1, 2022
Closed
@C-Otto C-Otto mentioned this issue Nov 1, 2022
Closed
@guggero guggero linked a pull request Nov 1, 2022 that will close this issue
wire: increase max witness items per input #1907
Merged
@seberm seberm mentioned this issue Nov 1, 2022
Closed
@seberm seberm mentioned this issue Nov 1, 2022
Open
@benthecarman benthecarman mentioned this issue Nov 1, 2022
Closed
@chappjc chappjc mentioned this issue Nov 1, 2022
Merged
@MevaTheProducer
Copy link

Hola a todos solo se Leer lo que escriben Todos mas no aplico en desarrollo jajajaj Bitcoin IS HERE the code is FREE :D

@remyers remyers mentioned this issue Nov 1, 2022
Merged
@notmandatory notmandatory mentioned this issue Nov 1, 2022
Closed
@cyclomancer cyclomancer mentioned this issue Jan 16, 2023
Open
@themoritz themoritz mentioned this issue Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wire: increase max witness items per input ellemouton/btcd
2 participants
@MevaTheProducer @brqgoo