Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow the class hierarchy to lookup a field #584

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Follow the class hierarchy to lookup a field #584

merged 5 commits into from
Oct 13, 2022

Conversation

GGGGGHT
Copy link
Contributor

@GGGGGHT GGGGGHT commented Oct 5, 2022

…oked up

#565

jbachorik
jbachorik requested changes Oct 8, 2022
View reviewed changes
Copy link
Collaborator

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
There are some open issues I would like you to solve before I can merge, though.

btrace-core/src/main/java/org/openjdk/btrace/core/BTraceUtils.java Outdated Show resolved Hide resolved
btrace-core/src/main/java/org/openjdk/btrace/core/BTraceUtils.java Outdated Show resolved Hide resolved
btrace-core/src/test/java/org/openjdk/btrace/core/BTraceUtilsTest.java Outdated Show resolved Hide resolved
@jbachorik jbachorik changed the title fix:When getting the fields in the class, the parent class is not looked up Follow the class hierarchy to lookup a field Oct 9, 2022
@GGGGGHT @jbachorik
Apply suggestions from code review
a55324b 
Co-authored-by: Jaroslav Bachorik <j.bachorik@gmail.com>
@jbachorik jbachorik merged commit d529136 into btraceio:develop Oct 13, 2022
@jbachorik jbachorik modified the milestones: 2.2.3, 2.3.0 Nov 10, 2022
@jbachorik jbachorik modified the milestones: 2.3.0, 2.2.3 Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@GGGGGHT @jbachorik