Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not drop CHECKCAST instructions #646

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Do not drop CHECKCAST instructions #646

merged 1 commit into from
Aug 6, 2023

Conversation

jbachorik
Copy link
Collaborator

@jbachorik jbachorik commented Aug 6, 2023

MethodVerifier was erroneously dropping CHECKCAST instructions, breaking verification for things like generified map access etc.

Fixes #644

@jbachorik jbachorik self-assigned this Aug 6, 2023
@jbachorik jbachorik added the Core label Aug 6, 2023
@jbachorik jbachorik added this to the 2.2.5 milestone Aug 6, 2023
@jbachorik jbachorik marked this pull request as ready for review August 6, 2023 09:50
@jbachorik jbachorik added this pull request to the merge queue Aug 6, 2023
Merged via the queue into develop with commit dd84c5d Aug 6, 2023
@jbachorik jbachorik deleted the jb/checkcast_fix branch August 6, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerifyError: Bad type on operand stack
1 participant