Half-open state does not keep rejecting, and doesn't trigger a later …

…re-try.
nodeshift · Dec 13, 2017 · 04df6f7 · 04df6f7
1 parent 9edc171
commit 04df6f7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/circuit.js b/lib/circuit.js
@@ -270,7 +270,7 @@ class CircuitBreaker extends EventEmitter {
       this.emit('cacheMiss');
     }
 
-    if (this.opened && !this.pendingClose) {
+    if (!this.closed && !this.pendingClose) {
       /**
        * Emitted when the circuit breaker is open and failing fast
        * @event CircuitBreaker#reject
@@ -432,7 +432,8 @@ function fail (circuit, err, args, latency) {
   const stats = circuit.stats;
   const errorRate = stats.failures / stats.fires * 100;
   if (errorRate > circuit.options.errorThresholdPercentage ||
-    circuit.options.maxFailures >= stats.failures) {
+    circuit.options.maxFailures >= stats.failures ||
+    circuit.halfOpen) {
     circuit.open();
   }
 }