feat: change default capacity from 10 to MAX_SAFE_INTEGER

nodeshift · Oct 2, 2018 · 4a8b98b · 4a8b98b
1 parent 82a9260
commit 4a8b98b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/circuit.js b/lib/circuit.js
@@ -74,7 +74,7 @@ class CircuitBreaker extends EventEmitter {
     this.options.rollingCountBuckets = options.rollingCountBuckets || 10;
     this.options.rollingPercentilesEnabled =
       options.rollingPercentilesEnabled !== false;
-    this.options.capacity = Number.isInteger(options.capacity) ? options.capacity : 10;
+    this.options.capacity = Number.isInteger(options.capacity) ? options.capacity : Number.MAX_SAFE_INTEGER;
 
     this.semaphore = new Semaphore(this.options.capacity);
 

diff --git a/test/test.js b/test/test.js
@@ -786,6 +786,12 @@ test('CircuitBreaker semaphore rate limiting', t => {
   });
 });
 
+test('CircuitBreaker default capacity', t => {
+  const breaker = circuit(passFail);
+  t.equals(breaker.options.capacity, Number.MAX_SAFE_INTEGER);
+  t.end();
+});
+
 const noop = _ => {};
 const common = require('./common');
 const identity = common.identity;