Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Columns Layout: static (px) #52

Closed
x9t9 opened this issue Jun 10, 2018 · 1 comment
Closed

2 Columns Layout: static (px) #52

x9t9 opened this issue Jun 10, 2018 · 1 comment
Labels

Comments

@x9t9
Copy link

x9t9 commented Jun 10, 2018

In the 2 Columns Layout: static (px) section, it seems that the handle div markup has been changed to a button ( not sure in which version )

Old markup :
<div title="Click to toggle" class="handlediv"><br></div>

New markup :

	<button type="button" class="handlediv" aria-expanded="true" >
	<span class="screen-reader-text">Toggle panel</span>
	<span class="toggle-indicator" aria-hidden="true"></span>
	</button>

the current version of the plugin does not display the toggle button .

@bueltge
Copy link
Owner

bueltge commented Jun 11, 2018

Thanks for the hint. Maybe you will send a PR?

@bueltge bueltge added the Bug label Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants