Bump google.golang.org/protobuf to v1.33.0 #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually pulls in the changes to go.mod - followup to #2800.
bufdev
approved these changes
Mar 5, 2024
|
We'll need to update to take into account protocolbuffers/protobuf#15164. |
bufdev
reviewed
Mar 5, 2024
| @@ -143,7 +143,9 @@ func (f *file) PyGenericServices() bool { | |||
| } | |||
|
|
|||
| func (f *file) PhpGenericServices() bool { | |||
| return f.fileDescriptor.GetOptions().GetPhpGenericServices() | |||
| // Support for PhpGenericServices was removed in | |||
There was a problem hiding this comment.
This isn't really the "right" fix, really we should be removing all of this. Give me a minute.
These are no longer valid. (Arguably, we could comment them out to reminder ourselves why they aren't here.)
bufdev
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually pulls in the changes to go.mod - followup to #2800.