Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rate limit of less than 1 request per second #113

Closed
kvigen opened this issue Sep 11, 2014 · 7 comments
Closed

Support rate limit of less than 1 request per second #113

kvigen opened this issue Sep 11, 2014 · 7 comments

Comments

@kvigen
Copy link

kvigen commented Sep 11, 2014

Since you can only specify an integer as the rate limiting field you can't rate limit to less than 1 request per second.

We would like to use this to forward large batch background job submissions from production to staging, and since these happen at a rate of less than once per second we can't limit them right now.

@buger
Copy link
Owner

buger commented Sep 11, 2014

Not sure what you mean, you can replicate traffic without any limitation, just not specify "limit".

@kvigen
Copy link
Author

kvigen commented Oct 7, 2014

Sorry, I wasn't being clear. I'm not sure how to do the following:

We get requests at a rate of 0.1 requests per second and we only want to replicate half those requests so we get 0.05 a second. Is there a way to do that given that you can filter at a rate lower than 1 per second?

@buger
Copy link
Owner

buger commented Oct 13, 2014

This one of the features i'm trying to implement for next release.

@buger
Copy link
Owner

buger commented Oct 26, 2014

@kvigen i'm going to merge #126 tomorrow. This should solve your problem by using percentage based limiting.

@kvigen
Copy link
Author

kvigen commented Oct 26, 2014

Thanks @buger!

@mattbostock
Copy link

Should this be closed now that #126 is merged?

@kvigen
Copy link
Author

kvigen commented Dec 3, 2014

Yes, thanks!

@kvigen kvigen closed this as completed Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants