-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alter values #57
Comments
We have decided to put the Koma53 values as default and KomaAE values optionally. There are two parts in code where the accidentals are manipulated: With @hsercanatli, we have to figure out which part we need to rewrite. |
It would be good to sync with the MusicXML people on this issue. See w3c/musicxml/#165 |
Please let me know if there are any further questions about the MusicXML accidental and alter elements that we can answer to help get this working better. Thank you for your work on this! |
Hi @mdgood, Thanks for the response! It seems that the conversion repository is going to be dormant for a while because the original author has left more or less a year ago and I am also leaving the CompMusic project. As a final step, I am discussing with @mogenslundholm on how to integrate his conversion tool for maintainability. I will let you know if there are any updates/doubts on our side. |
Right now, the alter values of the accidentals are either not entered or they are assigned to quarter tone shift: https://github.com/burakuyar/MusicXMLConverter/blob/master/musicxmlconverter/symbtrnote.py#L15-L17
We can directly enter the value of alter by computing from the value in KomaAE or Koma53 column. This option could be specified as an input during runtime. Since Koma53 has Kemal's corrections, it can be more suitable as the default.
The text was updated successfully, but these errors were encountered: