Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alter values #57

Open
sertansenturk opened this issue Jan 9, 2017 · 4 comments
Open

Fix alter values #57

sertansenturk opened this issue Jan 9, 2017 · 4 comments

Comments

@sertansenturk
Copy link
Collaborator

Right now, the alter values of the accidentals are either not entered or they are assigned to quarter tone shift: https://github.com/burakuyar/MusicXMLConverter/blob/master/musicxmlconverter/symbtrnote.py#L15-L17

We can directly enter the value of alter by computing from the value in KomaAE or Koma53 column. This option could be specified as an input during runtime. Since Koma53 has Kemal's corrections, it can be more suitable as the default.

@sertansenturk
Copy link
Collaborator Author

We have decided to put the Koma53 values as default and KomaAE values optionally.

There are two parts in code where the accidentals are manipulated:
https://github.com/burakuyar/MusicXMLConverter/blob/master/musicxmlconverter/symbtr2musicxml.py#L152-L171
https://github.com/burakuyar/MusicXMLConverter/blob/master/musicxmlconverter/symbtrnote.py#L232-L252

With @hsercanatli, we have to figure out which part we need to rewrite.

@sertansenturk
Copy link
Collaborator Author

It would be good to sync with the MusicXML people on this issue. See w3c/musicxml/#165

@mdgood
Copy link

mdgood commented Feb 21, 2017

Please let me know if there are any further questions about the MusicXML accidental and alter elements that we can answer to help get this working better. Thank you for your work on this!

@sertansenturk
Copy link
Collaborator Author

Hi @mdgood,

Thanks for the response! It seems that the conversion repository is going to be dormant for a while because the original author has left more or less a year ago and I am also leaving the CompMusic project.

As a final step, I am discussing with @mogenslundholm on how to integrate his conversion tool for maintainability.

I will let you know if there are any updates/doubts on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants