Skip to content
This repository has been archived by the owner on Sep 7, 2018. It is now read-only.

glob file excludes should work in buster config resources option #397

Closed
GCheung55 opened this issue Jan 30, 2014 · 2 comments
Closed

glob file excludes should work in buster config resources option #397

GCheung55 opened this issue Jan 30, 2014 · 2 comments
Assignees

Comments

@GCheung55
Copy link
Contributor

The resources option doesn't take a !files/to/exclude/*.js path.

The error I get is: '!files/to/exclude/*.js' matched no files.

@GCheung55
Copy link
Contributor Author

I think it has to do with https://github.com/busterjs/buster-configuration/blob/master/lib/group.js#L146-L167.

By following the code, I determined that addResource doesn't call resolvePathsAndAddMissingResources, but appendLoad does.

resolvePathsAndAddMissingResources eventually invokes expand which does the exclusions.

@dkl-ppi dkl-ppi added the Bug label Mar 7, 2014
@dkl-ppi dkl-ppi self-assigned this Mar 7, 2014
@dkl-ppi
Copy link
Member

dkl-ppi commented Mar 24, 2014

Implemented by 6745fc6.

@dkl-ppi dkl-ppi closed this as completed Mar 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants