Ensure editor instances in tests are properly torn down

bustle · Jun 23, 2016 · 90a1f5e · 90a1f5e
1 parent 9e41d7c
commit 90a1f5e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/tests/unit/editor/editor-events-test.js b/tests/unit/editor/editor-events-test.js
@@ -184,7 +184,7 @@ test('postDidChange callback fired when card payload changes', (assert) => {
       return $('<div id="my-simple-card">simple-card (edit)</div>')[0];
     }
   }];
-  editor = Helpers.mobiledoc.renderInto(editorElement, ({post, cardSection}) => {
+  let editor = Helpers.mobiledoc.renderInto(editorElement, ({post, cardSection}) => {
     return post([cardSection('simple-card')]);
   }, { cards });
 
@@ -205,6 +205,8 @@ test('postDidChange callback fired when card payload changes', (assert) => {
   postDidChange = 0;
   env.remove();
   assert.equal(postDidChange, 1, 'postDidChange called after remove');
+
+  editor.destroy();
 });
 
 test('inputModeDidChange callback fired when markup is toggled and there is a selection', (assert) => {

diff --git a/tests/unit/editor/editor-test.js b/tests/unit/editor/editor-test.js
@@ -308,7 +308,7 @@ test('editor parses HTML post using parser plugins', (assert) => {
     seenTagNames.push(element.tagName);
   };
   let html = '<p><textarea></textarea><img></p>';
-  let editor = new Editor({html, parserPlugins: [parserPlugin]});
+  editor = new Editor({html, parserPlugins: [parserPlugin]});
   assert.ok(!!editor.post, 'editor loads post');
 
   assert.deepEqual(seenTagNames, ['TEXTAREA', 'IMG']);