Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sso-proxy: signature mismatch on empty cookie value #142

Closed
jphines opened this issue Jan 18, 2019 · 0 comments
Closed

sso-proxy: signature mismatch on empty cookie value #142

jphines opened this issue Jan 18, 2019 · 0 comments

Comments

@jphines
Copy link
Contributor

jphines commented Jan 18, 2019

Describe the bug
SSO Proxy can send a blank cookie header which is then used as part of the request signature which can be confusing to implement for upstream signature verifiers.

This bug is a result of the way sso removes the session cookie when it was the only cookie. In this case, it stores an empty string as a single item in a string slice. This empty string is then used as part of the signature. The specification is unclear what to do when empty values are encountered.

Expected behavior

  • Do not proxy empty cookie headers and prevent from being used as part of the signature
  • The signer should then specify and ignore empty strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant