Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading configuration from a file #231

Open
omerlh opened this issue Jul 22, 2019 · 1 comment
Open

Add support for reading configuration from a file #231

omerlh opened this issue Jul 22, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@omerlh
Copy link

omerlh commented Jul 22, 2019

Is your feature request related to a problem? Please describe.
Storing sensitive configuration in an environment variables is not considered as best practices.

Describe the solution you'd like
Allow reading configuration from a file or from a cli argument (look like it's supported by the config lib that in use).

@Jusshersmith Jusshersmith added the enhancement New feature or request label Aug 6, 2019
@Jusshersmith
Copy link
Contributor

Hi @omerlh! 👋

Thanks for sending this through. As you mentioned, the configuration library that we're now making use of (as of v2.0.0) should help with this! I believe we're still looking to utilise that library on the proxy side (right now, it's only being used by the auth side I believe), but once that's done I think this should be much more achievable.

I hope that is something that we can implement in the not too distant future. Though I wouldn't necessarily expect the abstraction of being able to store these variables in a file would be included in that change set; I don't think it's something we (BuzzFeed) would be able to prioritise, but I'll aim to post back here once we've finished the initial change set to clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants