Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow injection of request headers in proxy #243

Closed
mcfearsome opened this issue Aug 12, 2019 · 3 comments
Closed

Allow injection of request headers in proxy #243

mcfearsome opened this issue Aug 12, 2019 · 3 comments

Comments

@mcfearsome
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I am setting sso up in front of a Kibana instance that is created using the ECK operator. This does not allow me to turn off the xpack security feature (I can on Kibana but am unable to for Elasticsearch which causes issues for Kibana). In order to avoid having the user login twice I would like to be able to include the basic auth credentials in the upstream config.

Describe the solution you'd like
Add new option to the UpstreamConfig similar to HeaderOverrides

Describe alternatives you've considered
I could not use the ECK operator and run ES without any security at all, would prefer to not do that

@jphines
Copy link
Contributor

jphines commented Aug 12, 2019

@mcfearsome I believe setting HeaderOverrides will work in this case to inject new headers. Does it not?

@mcfearsome
Copy link
Contributor Author

@jphines HeaderOverrides looks to be for Response Headers not adding onto the request before it hits the proxied service. I have a PR incoming (never wrote Go before so go easy)

@mcfearsome
Copy link
Contributor Author

Just to make sure I wasn't being dumb I double checked using HeaderOverrides with the current value that is working with InjectRequestHeaders and it does not work (but is present in the Response Headers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants