Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build static assets into go binary #7

Closed
loganmeetsworld opened this issue Aug 22, 2018 · 3 comments
Closed

build static assets into go binary #7

loganmeetsworld opened this issue Aug 22, 2018 · 3 comments
Labels
enhancement New feature or request papercuts frustrations to fix but not necessarily a bug

Comments

@loganmeetsworld
Copy link
Contributor

loganmeetsworld commented Aug 22, 2018

Is your feature request related to a problem? Please describe.
Currently, static assets are not built into the binary.

Describe the solution you'd like
We can build the static assets into the go binary to make it easier to pull and use the Docker image without needing to mount the static directory.
We can use go-bindata to compile static images into our go binary, similar to what is done in go-httpbin

danbf pushed a commit that referenced this issue Aug 22, 2018
@loganmeetsworld loganmeetsworld changed the title circle-ci: build static assets into go binary build static assets into go binary Aug 24, 2018
@shrayolacrayon shrayolacrayon added enhancement New feature or request papercuts frustrations to fix but not necessarily a bug labels Aug 24, 2018
@sporkmonger
Copy link
Contributor

sporkmonger commented Sep 18, 2018

Another option I've had good luck with is https://github.com/rakyll/statik, and I'd recommend it over go-bindata as it's actively maintained.

@sporkmonger
Copy link
Contributor

I'm putting together a PR for this.

@sporkmonger
Copy link
Contributor

PR's ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request papercuts frustrations to fix but not necessarily a bug
Projects
None yet
Development

No branches or pull requests

3 participants