CI: remove requirement to pull in dependency source code changes #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. |
jphines
reviewed
Mar 27, 2019
Change commands ran and their order in ./scripts/test to prevent source code from dependencies being pulled in on each build, while still verifying required dependencies. Also enable GO111MODULE in the Dockerfile to allow use of modules while in the $GOPATH. changes from review
By running ./scripts/test and `make tools`.
Jusshersmith
force-pushed
the
jusshersmith-change-tests
branch
from
d1bfabe
to
dedc381
Compare
jphines
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All CI builds are currently failing due to updates to vendored dependencies being required. Specifically, we run git diff as part of our tests (https://github.com/buzzfeed/sso/blob/master/scripts/test) which fails after the CI process itself tries to update these dependencies. Due to the use of
go mod vendorwe currently need to pull in updated source code for these dependencies too.Solution
We don't want to have to update the source code for vendored dependencies on each build - instead this can be done intermittently after a certain time period or when we want to pull in updates from certain dependencies. This PR aims to take away that requirement.
Commit 0c2c289 includes changes to
./scripts/testandDockerfileto prevent dependency source code being pulled down on each build, and to allow use of modules within the $GOPATH.Commit d1bfabe includes changes to
go.modandgo.sumfrom running./scripts/testandmake tools.Notes
One potential issue not addressed in this PR is that if any changes to
go.sumandgo.modare caused by https://github.com/buzzfeed/sso/blob/master/Makefile#L18-L20, then the build will fail due to git diffs. Running./scripts/testdoes not make these updates, so currentlymake toolsneeds to be locally ran to pull in these changes.Relevant PR: #166 (this was initially created to simply make the required dependency changes to unblock builds, however now should not be needed)