sso: send access token on group information query #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jusshersmith
previously approved these changes
Apr 2, 2019
shrayolacrayon
previously approved these changes
Apr 3, 2019
jphines
dismissed stale reviews from shrayolacrayon and Jusshersmith
via
3594c83
jphines
force-pushed
the
jhines-okta-send-access-token
branch
from
c75733d
to
3594c83
Compare
Jusshersmith
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Not all identity providers provide the same API for access groups. This is especially true for Google which has a rather strange mechanism for fetching group information.
Most identity providers, including Okta, require an individuals access token in order to query information about their groups. However, our abstractions now do not consider this and don't allow for this case.
Solution
We pass on the access token now for all identity providers, even if not all identity providers (like Google) require it. This will prove useful and necessary when we get further along for adding access for Okta as an identity provider, which does require it.