Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sso_auth: use hostmux and ping #205

Merged
merged 1 commit into from
May 31, 2019
Merged

sso_auth: use hostmux and ping #205

merged 1 commit into from
May 31, 2019

Conversation

jphines
Copy link
Contributor

@jphines jphines commented May 29, 2019

Problem

The previous mux solution was slightly confusing and didn't allow for /ping to the configured host header!

Solution

We already implement a host router, we can use it here and wrap the /ping endpoint via middleware.

@jphines jphines added the bug Something isn't working label May 29, 2019
@jphines jphines requested a review from Jusshersmith May 29, 2019 18:54
@jphines jphines self-assigned this May 29, 2019
@jphines jphines merged commit d0f7997 into master May 31, 2019
@jphines jphines deleted the jhines-fix-ping branch May 31, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrayolacrayon shrayolacrayon shrayolacrayon approved these changes

@Jusshersmith Jusshersmith Awaiting requested review from Jusshersmith

Assignees

@jphines jphines

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jphines @shrayolacrayon