ci: integrate with Codecov for test coverage #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=========================================
Coverage ? 62.34%
=========================================
Files ? 49
Lines ? 4002
Branches ? 0
=========================================
Hits ? 2495
Misses ? 1352
Partials ? 155 |
Jusshersmith
commented
Jun 12, 2019
| layout: "header, diff" | ||
| behavior: default | ||
| require_changes: no | ||
|
|
There was a problem hiding this comment.
This is largely a default config, with the only changes so far being:
- removal of notifications for the time being
- lowered the 'range' (preferred range, among other settings to be decided)
There was a problem hiding this comment.
Also added a list of files that are impacted by the pull request and their coverage to the PR comment that is left.
Jusshersmith
commented
Jun 12, 2019
|
What do we need to merge this @Jusshersmith ? |
|
@jphines I think it's fine to merge as is - we'll work out the exact configuration we prefer as time goes on, but everything seems to be working well enough to start with! Also once this is merged I think the reports become more useful as they'll have master to compare against. |
jphines
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We already try hard to make sure code has appropriate tests written, however we don't currently provide an easy way to monitor and track test coverage.
Solution
Integrate the sso repo with a tool like Codecov, which helps us track and monitor coverage reports and make them a prominent part of pull requests and the contribution workflow.
Notes
This currently uses the Codecov bash uploader to upload coverage reports, which is one of the recommended methods. Other methods include updating CircleCI to version 2.1 and making use of CircleCI orbs.
Specific settings for codecov to be decided - this PR has been created with defaults.