sso_auth: fix client authentication for revoke endpoint #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
/oauth2/sign_out
does not currently work with the Okta provider:is returned, and the request to sign the user out is unsuccessful.
Solution
This PR adds client authentication for the
Revoke
function (I think this must have been lost during development?), which is used to sign out via the/oauth2/sign_out
endpoint.Notes
Client authentication is provided using the same method as in the
ValidateSessionState
function:sso/internal/auth/providers/okta.go
Lines 117 to 123 in 521ff9c