-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sso: update go modules #273
Conversation
diff created by running scripts/test
Should we also add |
Yeah, I think that sounds like a sensible idea @mccutchen! |
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=======================================
Coverage 62.21% 62.21%
=======================================
Files 54 54
Lines 4200 4200
=======================================
Hits 2613 2613
Misses 1399 1399
Partials 188 188 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from one small nit, thanks @Jusshersmith!
Think I'm going to need a fresh review on this @mccutchen! (thanks!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Jusshersmith!
Problem
Updates to certain go modules are required. This is starting to cause errors with new builds: https://circleci.com/gh/buzzfeed/sso/2185?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Solution
Running https://github.com/buzzfeed/sso/blob/master/scripts/test locally edited
go.mod
andgo.sum
files as required.