Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: update to project threshold to explicit % #283

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

Jusshersmith
Copy link
Contributor

Problem

Codecov appears to be incorrectly failing some pull request checks due to the project status check. If I understand correctly, our Codecov configuration should mean that the project check should fail if the change results in a 2% drop in overall coverage.

#279 is failing due to a 0.47% drop in project coverage.

Solution

It seems the Codecov docs have been updated to show the threshold being set explicitly as a %, and some past issues seem to suggest that this may affect how it works, e.g. https://community.codecov.io/t/threshold-confusion/88.
It's unclear if this is the cause, but seems sensible to update regardless and to rule it out.

jphines
jphines previously approved these changes Mar 4, 2020
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   61.85%   61.85%           
=======================================
  Files          57       57           
  Lines        4638     4638           
=======================================
  Hits         2869     2869           
  Misses       1556     1556           
  Partials      213      213

@Jusshersmith Jusshersmith merged commit a8f495b into master Mar 30, 2020
@Jusshersmith Jusshersmith deleted the jusshersmith-update-codecov branch March 30, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants