codecov: update to project threshold to explicit % #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Codecov appears to be incorrectly failing some pull request checks due to the
project
status check. If I understand correctly, our Codecov configuration should mean that theproject
check should fail if the change results in a 2% drop in overall coverage.#279 is failing due to a 0.47% drop in project coverage.
Solution
It seems the Codecov docs have been updated to show the threshold being set explicitly as a
%
, and some past issues seem to suggest that this may affect how it works, e.g. https://community.codecov.io/t/threshold-confusion/88.It's unclear if this is the cause, but seems sensible to update regardless and to rule it out.