Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sso_*: use ProxyFromEnvironment in http Transport #307

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

Jusshersmith
Copy link
Contributor

@Jusshersmith Jusshersmith commented Jun 2, 2021

Problem

As described in #305, some HTTP clients used in sso_auth and sso_proxy don't allow for use of HTTP_PROXY environment variables -- meaning traffic can't be passed through a proxy if desired.

Solution

Make use of the http.ProxyFromEnvironment method, which allows for usage of these environment variables.

We already make use of this in one HTTP client within sso_proxy here:

Proxy: http.ProxyFromEnvironment,

jphines
jphines previously approved these changes Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #307 (26d56b0) into main (290f27e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files          58       58           
  Lines        4286     4286           
=======================================
  Hits         2689     2689           
  Misses       1382     1382           
  Partials      215      215           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290f27e...26d56b0. Read the comment docs.

@Jusshersmith Jusshersmith force-pushed the jusshersmith-auth-ProxyFromEnvironment branch from 71d9c08 to 26d56b0 Compare June 14, 2021 16:40
@Jusshersmith Jusshersmith merged commit f02c1fc into main Jun 16, 2021
@Jusshersmith Jusshersmith deleted the jusshersmith-auth-ProxyFromEnvironment branch June 16, 2021 09:56
@Jusshersmith Jusshersmith changed the title sso_auth: use ProxyFromEnvironment in http Transport sso_*: use ProxyFromEnvironment in http Transport Jun 16, 2021
@Jusshersmith Jusshersmith added the enhancement New feature or request label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants