sso_*: use ProxyFromEnvironment in http Transport #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #305, some HTTP clients used in
sso_auth
andsso_proxy
don't allow for use ofHTTP_PROXY
environment variables -- meaning traffic can't be passed through a proxy if desired.Solution
Make use of the http.ProxyFromEnvironment method, which allows for usage of these environment variables.
We already make use of this in one HTTP client within
sso_proxy
here:sso/internal/proxy/reverse_proxy.go
Line 53 in 03e1259