Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing direction prop on the fly #104

Closed
gpmcadam opened this issue Dec 11, 2018 · 4 comments
Closed

Changing direction prop on the fly #104

gpmcadam opened this issue Dec 11, 2018 · 4 comments
Labels
😭 bug Something isn't working 💬 discussion

Comments

@gpmcadam
Copy link

There's instances where you might want to dynamically set the scroll direction property, and doing so on the fly doesn't update the list until it is scrolled or otherwise observed.

Should this prop update the list, similar to how re-setting itemSize will cause a re-render?

@bvaughn
Copy link
Owner

bvaughn commented Dec 11, 2018

Hm. Can you describe an example of this?

On the one hand, I would expect changing the prop to re-render the list. On the other hand, I never considered this an actual/valid use case. Seems like it would make for a pretty odd user experience?

Either way, I should either make it work or add a DEV warning. I'm leaning toward the latter, but let's talk about it.

@bvaughn bvaughn added 😭 bug Something isn't working 💬 discussion labels Dec 11, 2018
@gpmcadam
Copy link
Author

@bvaughn an example would be if you resize the window and for responsive reasons want to change the placement of a list on the screen

@bvaughn
Copy link
Owner

bvaughn commented Dec 17, 2018

That still seems pretty unusual/unexpected to me. Can you show me an example of an actual website that does this?

@bvaughn
Copy link
Owner

bvaughn commented Dec 21, 2018

Fixed via #112

@bvaughn bvaughn closed this as completed Dec 21, 2018
@bvaughn bvaughn mentioned this issue Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😭 bug Something isn't working 💬 discussion
Projects
None yet
Development

No branches or pull requests

2 participants