Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlayAudioFile never returns when not ready #8

Open
jD91mZM2 opened this issue Apr 21, 2017 · 2 comments
Open

PlayAudioFile never returns when not ready #8

jD91mZM2 opened this issue Apr 21, 2017 · 2 comments

Comments

@jD91mZM2
Copy link
Contributor

When you return at https://github.com/bwmarrin/dgvoice/blob/master/dgvoice.go#L116, which means https://github.com/bwmarrin/dgvoice/blob/master/dgvoice.go#L195 waits forever, and never returns. I'd suggest closing the channel or something
@jD91mZM2
Copy link
Contributor Author

jD91mZM2 commented Apr 21, 2017 •
edited
Loading

Another thing, printing an error there is not the best of ideas. Because everytime PlayAudioFile closes, it throws an error because SendPCM continues to live on.

@bwmarrin
Copy link
Owner

I think there's a lot of room for improvement here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwmarrin @jD91mZM2