Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for null values #734

Open
JurrijnP opened this issue Feb 3, 2020 · 1 comment
Open

Support for null values #734

JurrijnP opened this issue Feb 3, 2020 · 1 comment

Comments

@JurrijnP
Copy link
Contributor

JurrijnP commented Feb 3, 2020

I have been looking into endpoints where null values would be needed for some states. Good example is #571. After trying some stuff I do think the best solution would be something like in #700.

This however would be breaking quite some functions if you'd add support for all cases. However I think it would be perfect for a V2 of this library. You can think of having NullString, NullBool etc.
If somebody knows something else please show.

@JurrijnP JurrijnP changed the title [Majorly breaking] Support for null values Support for null values Mar 3, 2020
@JurrijnP
Copy link
Contributor Author

JurrijnP commented Mar 3, 2020

I have made a PR (#744) to support the null values. This does not solve the issue of resetting a struct field, i.e. Embed in MessageEdit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant