Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to wasm-tools validate docs #1090

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

michelleN
Copy link
Contributor

  • Adds where to find available wasm feature options
  • Adds how to see more verbose output in case folks want to see more details of what is being validated

+ Adds where to find available wasm feature options
+ Adds how to see more verbose output in case folks
want to see more details of what is being validated

Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If you're feeling particularly intrepid the error message here could theoretically be improved with something like "didn't recognize foo but valid features are bar, baz, ...". Or something like --wasm-features help would print them all out or something like that. In any case no need to happen here-and-now, just if you're interested!

@alexcrichton alexcrichton merged commit e18dc3d into bytecodealliance:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants