Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to release a patch 12.0.1 #6889

Closed
TimonPost opened this issue Aug 23, 2023 · 2 comments
Closed

Is it possible to release a patch 12.0.1 #6889

TimonPost opened this issue Aug 23, 2023 · 2 comments

Comments

@TimonPost
Copy link
Contributor

TimonPost commented Aug 23, 2023 •
edited
Loading

On the 7th of August #6804 was merged which gives us quite some improvement in module compilation times. We hoped to get this feature in 0.12 but as it was merged with main 2 days after the 12.0 branch was created (the 5th) it hasn't been released. Is it possible to release a patch 12.0.1 with this commit? Also, this means the RELEASES #6838 is not correct as this change was not included in 12.0
@TimonPost TimonPost changed the title Is it possible to release a patch 0.12 Is it possible to release a patch 0.12.1 Aug 23, 2023
@TimonPost TimonPost changed the title Is it possible to release a patch 0.12.1 Is it possible to release a patch 12.0.1 Aug 23, 2023
@TimonPost TimonPost mentioned this issue Aug 23, 2023
Open
@alexcrichton
Copy link
Member

Personally I think this is fine to do at this time. Would you be up for sending a PR to backport that change to the 12.0.0 release branch?

@TimonPost TimonPost mentioned this issue Aug 24, 2023
Merged
@alexcrichton
Copy link
Member

Done now via #6897 and #6901, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @TimonPost