Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SI unit should be decimal units #25

Open
EFanZh opened this issue Apr 11, 2021 · 2 comments · May be fixed by #38
Open

SI unit should be decimal units #25

EFanZh opened this issue Apr 11, 2021 · 2 comments · May be fixed by #38
Labels
enhancement
Milestone
2.0

Comments

@EFanZh
Copy link

EFanZh commented Apr 11, 2021

Currently, the effect of the si_unit argument of ByteSize::to_string_as seems to be reversed. According to Wikipedia, SI units are decimal units, and IEC units are binary units.
@wookietreiber
Copy link

I highly recommend using an enum with SI and IEC variants instead of a bool, as this is so much clearer in code.

@Andrew15-5 Andrew15-5 linked a pull request Oct 6, 2023 that will close this issue
Open
@MrCroxx MrCroxx added the Q & A label Nov 18, 2024
@MrCroxx MrCroxx added this to the 2.0 milestone Nov 18, 2024
@MrCroxx MrCroxx added enhancement and removed Q & A labels Nov 18, 2024
@MrCroxx
Copy link
Collaborator

MrCroxx commented Nov 18, 2024

Planned with 2.0 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Fixed inverted SI conditions (and related things) Andrew15-5/bytesize
3 participants
@wookietreiber @EFanZh @MrCroxx