Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent time unit #179

Closed
clayton33 opened this issue Jul 24, 2024 · 4 comments · Fixed by #180
Closed

consistent time unit #179

clayton33 opened this issue Jul 24, 2024 · 4 comments · Fixed by #180
Assignees

Comments

@clayton33
Copy link

I've recently started to process a handful of our Sea Explorer missions and we (@dankelley and @richardsc) noticed that the unit for time varies between the timeseries, profiles, and grid netCDF files. Currently the units are the following from the associated function

function time unit
seaexplorer.raw_to_timeseries milliseconds since 1970-01-01T00:00:00+00:00
ncprocess..extract_timeseries_profiles seconds since 1970-01-01T00:00:00+00:00
ncprocess.make_gridfiles nanoseconds since 1970-01-01T00:00:00+00:00

Perhaps they should all be seconds since 1970-01-01T00:00:00+00:00 to follow recent changes made to the ncprocess.extract_timeseries_profiles ?

@jklymak
Copy link
Member

jklymak commented Jul 24, 2024

Yes I agree. Sorry for the inconsistencies - I hadn't appreciated how important keeping these consistent was but it does screw up various processing if the units change so this should be standardized

@jklymak
Copy link
Member

jklymak commented Jul 25, 2024

@callumrollo does it make sense to fix this? xarray makes these issues seamless, but I've had complaints from my Matlab users about the time changing units, and perhaps R-users have a similar issue. I think for ERDAPP ingestion it is also better to be float64 in seconds since 1970.

@callumrollo
Copy link
Collaborator

Yes it makes sense to impose consistency in the time units in SeaExplorer processing. We currently do it as part of our post processing. I'll work on a PR next week to standardise on float64 seconds since 1970

@callumrollo callumrollo self-assigned this Jul 25, 2024
@callumrollo
Copy link
Collaborator

There are some other improvements I'd like to make to the SeaExplorer processing now that there is a stable version 1 release of polars, so it's a good time for an overhaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants