Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time range selection to study page KM plots #10152

Closed
alisman opened this issue May 3, 2023 · 0 comments · Fixed by cBioPortal/cbioportal-frontend#4645
Closed

Add time range selection to study page KM plots #10152

alisman opened this issue May 3, 2023 · 0 comments · Fixed by cBioPortal/cbioportal-frontend#4645
Assignees

Comments

@alisman
Copy link
Contributor

alisman commented May 3, 2023

A la the scatter and bar charts on study page, we want the user to able to drag select an x range of the chart and apply this as a filter on SV. This should be possible with the existing clinical data numeric filters.

Note that there are multiple kinds of km plots, one for each different type of related clinical data. You will find some code to detect these types and create the corrresponding charts.

Also, @dippindots has recently introduced "binning" as optimization to km plots with a lot of data. Normally the x axis is in days, but when there's a lot of data, we do it by month. You will need to make sure that your selection takes this into account. May or may not be simple.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants