Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to disable data download but still allow figure download #10180

Closed
jjgao opened this issue May 18, 2023 · 2 comments · Fixed by cBioPortal/cbioportal-frontend#4662 or #10264
Closed

Comments

@jjgao
Copy link
Member

jjgao commented May 18, 2023

The skin.hide_download_controls property implemented in #8529 & cBioPortal/cbioportal-frontend#3716 will completely hide the download controls including data and figures. Was the main concern downloading data? Should we still allowing figure download? One argument is that people will still be able to make screenshots so it's really not possible to disable figure download...

Currently, skin.hide_download_controls can be "true" or "false". Let's add another option "data", which will disable data download but not figure download.

@jjgao
Copy link
Member Author

jjgao commented May 18, 2023

Also, there are useful functionalities in the Download tab of results view page, e.g. go to the altered cohort... I am wondering if we should still keep the tab but disable download functions there?

@jjgao
Copy link
Member Author

jjgao commented Jun 22, 2023

Here are the various places that we should disable data download when skin.hide_download_controls=data.

  • Study view, e.g. https://www.cbioportal.org/study/summary?id=brca_tcga_pub:

    • Download widget to download all clinical data - this should be disabled.
      image
    • Pie chart. Only disable Full Data download
      image
    • Bar chart. Only disable Data download
      image
    • Various tables. Disable Data download
      image
    • Clinical Data tab - disable download
    • CN Segments tab - disable download
  • Comparision https://www.cbioportal.org/comparison/overlap?sessionId=5cf89323e4b0ab413787436c

    • disable download Data / TSV in all tab
  • Results https://bit.ly/42P95PL

    • Download tab - let's keep these three for Downloadable Data Files section
      image
    • Download tab - keep download option for Gene Alteration Frequency section
    • Download tab - disable download in Type of Genetic Alterations Across All Samples section
    • Cancer Types Summary - no need to remove the download functionality since it's not patient-level data
    • Mutual Exclusivity - no need to remove
    • Plots tab - remove download Data
    • Mutations tab - remove download TSV from table
    • Co-expression tab - no need to remove
    • Comparison/Survival - the same as Comparision view above
    • CN Segments - remove download
    • Pathways - no need to remove
    • OncoPrint - remove Tabular and Open in OncoPrinter in Download menu
  • Patient view https://www.cbioportal.org/patient?studyId=ucec_tcga_pub&caseId=TCGA-BK-A0CC

    • Disable all download widgets since all of them are "Download TSV"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants