Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front End README is unclear on how to run unit tests #7095

Closed
ecerami opened this issue Feb 1, 2020 · 3 comments · Fixed by cBioPortal/cbioportal-frontend#3042
Closed

Front End README is unclear on how to run unit tests #7095

ecerami opened this issue Feb 1, 2020 · 3 comments · Fixed by cBioPortal/cbioportal-frontend#3042
Assignees

Comments

@ecerami
Copy link
Contributor

ecerami commented Feb 1, 2020

In the current Front End README file, it says:

To run unit/integration tests (need to have API URL defined in .env)

But, I am not sure what this means:

  • What is .env? Do we create one locally?
  • What is the API URL used for?
  • What value should we set for API URL?

Am happy to update the docs to explain, but I don't know the answers to the above.

Tagging @alisman @Luke-Sikina for help.

@ecerami ecerami self-assigned this Feb 1, 2020
@Luke-Sikina
Copy link
Member

Luke-Sikina commented Feb 3, 2020

To run unit/integration tests (need to have API URL defined in .env)

@inodb you added the quoted line about 3 years ago. I don't have a .env and tests pass for me. Does .env still serve a purpose?

@inodb
Copy link
Member

inodb commented Feb 3, 2020

.env is legacy. Can be removed

@ecerami
Copy link
Contributor Author

ecerami commented Feb 3, 2020

Ok, I can update the README to remove .env. But, I still can't get the unit tests to run to the end. See #7096. Once I figure that out, I can circle back here and update the README docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants