Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration doesn't read region from environment variable AWS_REGION #51

Open
Triforcey opened this issue Jul 26, 2018 · 1 comment
Open

Comments

@Triforcey
Copy link

Triforcey commented Jul 26, 2018

The documentation for the AWS SDK mentions being able to set the AWS region via an environment variable here. connect-dynamodb doesn't yet respect this environment variable. If the developer is unaware of this it can lead to the session table being hosted in a different region than the rest of the database.

@lancegliser
Copy link
Contributor

Will need to retest this after #76 . If it stays as written the only methods for getting a client will be:

  • Manual creation to pass in as client
    Fully the developer's resonsibility.
  • Native new DynamoDBClient() functionality.
    I think it covers the variable you've mentioned, or at least does what developer would expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants