Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can’t generate JsonSchema due to missing JsonSchema implementation for IpNetwork #12

Open
cab404 opened this issue May 10, 2022 · 1 comment
Open

Can’t generate JsonSchema due to missing JsonSchema implementation for IpNetwork #12

cab404 opened this issue May 10, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cab404
Copy link
Owner

cab404 commented May 10, 2022 •
edited
Loading

I’ve tried adding JsonSchema for our config (because having one will allow us adding custom config editors with validation and stuff). However, I was blocked on missing implementation of JsonSchema for IpNetwork. We either need to somehow pass it through into JsonSchema derive macro, or add implemetation to IpNetwork crate itself.

Related: achanda/ipnetwork#153
@cab404 cab404 added enhancement New feature or request good first issue Good for newcomers labels May 10, 2022
@sancho20021
Copy link
Contributor

I opened a PR to ipnetwork crate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cab404 @sancho20021