Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for "cachethq/docker:base-5a0320b"? #35

Closed
andygrunwald opened this issue Jan 25, 2016 · 8 comments
Closed

Dockerfile for "cachethq/docker:base-5a0320b"? #35

andygrunwald opened this issue Jan 25, 2016 · 8 comments

Comments

@andygrunwald
Copy link
Contributor

Hey,

the Dockerfile is based upon FROM cachethq/docker:base-5a0320b.
Where can i find the definition of the image cachethq/docker:base-5a0320b?

@andygrunwald
Copy link
Contributor Author

I found it here: https://github.com/CachetHQ/Docker/blob/base-5a0320b/Dockerfile

There my question is: Why this is not included in the original Dockerfile?

@djdefi
Copy link
Contributor

djdefi commented Jan 25, 2016

Mainly to help speed up builds for testing different versions. See #4 and #1.

At this point it isn't really needed I suppose, as the longest build step is the Cachet install anyway. Maybe we will kill this for 2.1.0 or something.

@andygrunwald
Copy link
Contributor Author

This would be great. In my opinion the build speed is not so important, because everything is automated via docker hub. And in the end you don`t build this image every minute, so it has the advantage to create a bigger transparency how this image is build

@andygrunwald
Copy link
Contributor Author

Should i drop a PR?

@djdefi
Copy link
Contributor

djdefi commented Jan 26, 2016

Sure 👍

Sent from my iPhone

On Jan 26, 2016, at 12:43 AM, Andy Grunwald notifications@github.com wrote:

Should i drop a PR?


Reply to this email directly or view it on GitHub.

@andygrunwald
Copy link
Contributor Author

Why are there ca-certificates and git installed? Are they in use?
I think they can be removed, or am i wrong?

Checkout the PR here: #37

@djdefi
Copy link
Contributor

djdefi commented Jan 26, 2016

@andygrunwald I believe that is leftover from doing git clone rather than downloading the release archives. Feel free to remove if it is not needed :)

@jbrooksuk
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants