Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component notifications can be silenced #2318

Merged
merged 2 commits into from
Feb 6, 2017
Merged

Conversation

jbrooksuk
Copy link
Member

Fixes #2316


You can now supply silent as a boolean parameter. If true then we won't notify about component status changes.

@jbrooksuk jbrooksuk self-assigned this Jan 16, 2017
@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jan 16, 2017
@joecohens
Copy link
Contributor

@jbrooksuk Looks ok! This will silent all notifications for a component right? But what happens if I just don't want to notify users a single time and then they can keep getting updates?

@jbrooksuk
Copy link
Member Author

This is just per-update. If you silence once, the next time it won't be unless you specify again. Or am I misunderstanding?

@joecohens
Copy link
Contributor

Lol true, my bad 😉

[ci skip] [skip ci]
@jbrooksuk
Copy link
Member Author

Merging this tonight 👍

@jbrooksuk jbrooksuk merged commit 47df0eb into 2.4 Feb 6, 2017
@jbrooksuk jbrooksuk deleted the silent-component-changes branch February 6, 2017 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants